Hi,

In order for koji to build from git, it must retrieve sources from the lookaside cache. I believe that's the only reason the 'fedpkg' package is required in a build target's 'srpm-build' group.

The default fedpkg.conf installed by the RPM is configured with the Fedora lookaside server URLs. Of course that doesn't work in my shop, where we run our own koji infra.

I hacked koji to pull the host's /etc/fedpkg.conf file into the mock chroot, the same way koji does out of the box with /etc/hosts. The patch is attached.

Koji and the Fedora packaging tools have been great tools for us. We're using koji, mock, sigul, fedpkg and other components. It's been a little frustrating at times, though, frequently dealing with what seems like configuration data that's hardcoded into the source.

I'm guessing that addressing that is low-priority, since the main consumers of these tools are the users of the Fedora build infrastructure. I occasionally get the bug to 'fix' stuff. Most recently, I set up a subclassed fedpkg tool that works with the peculiarities of our configuration (configuration locations, branch nomenclature, etc.). It turned out to be a bit hairy, and it wouldn't be tough to fix fedpkg. Would patches be welcome? It would be pretty valuable to have private instances supported a little better.

Thanks-

        John




--- koji-1.7.0/koji/__init__.py~        2012-05-31 14:05:43.000000000 -0500
+++ koji-1.7.0/koji/__init__.py 2012-08-31 17:48:54.411897132 -0500
@@ -1266,6 +1266,9 @@
         etc_hosts = file('/etc/hosts')
         files['etc/hosts'] = etc_hosts.read()
         etc_hosts.close()
+        fedpkg_conf = file('/etc/rpkg/fedpkg.conf')
+        files['etc/rpkg/fedpkg.conf'] = fedpkg_conf.read()
+        fedpkg_conf.close()
     mavenrc = ''
     if opts.get('maven_opts'):
mavenrc = 'export MAVEN_OPTS="%s"\n' % ' '.join(opts['maven_opts'])
--- koji-1.7.0/koji/__init__.py~        2012-05-31 14:05:43.000000000 -0500
+++ koji-1.7.0/koji/__init__.py 2012-08-31 17:48:54.411897132 -0500
@@ -1266,6 +1266,9 @@
         etc_hosts = file('/etc/hosts')
         files['etc/hosts'] = etc_hosts.read()
         etc_hosts.close()
+        fedpkg_conf = file('/etc/rpkg/fedpkg.conf')
+        files['etc/rpkg/fedpkg.conf'] = fedpkg_conf.read()
+        fedpkg_conf.close()
     mavenrc = ''
     if opts.get('maven_opts'):
         mavenrc = 'export MAVEN_OPTS="%s"\n' % ' '.join(opts['maven_opts'])
--
buildsys mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/buildsys

Reply via email to