Mike McLean ([email protected]) said: > On 12/17/2012 03:14 PM, Bill Nottingham wrote: > >Bill Nottingham ([email protected]) said: > >>Only include groups that are specified in the kickstart. Remove any > >>environments that use groups not on the media. > > > >Anyone? Bueller? > > I'm not really familiar with the pungi code, but it looks sane > enough to me. Just one comment... > > If the kickstart references groups that do not exist in comps, it > looks like this will silently ignore them. I don't know what the old > behavior was, but it might be worth reporting, e.g. > > if g: > ourgroups.append(g.groupid) > else: > self.logger.info('Ignoring unknown group %s from kickstart > file', item.name)
This filtering is when writing the comps file out to the media - there should already be logging on the compose path earlier when a kickstart references a group that doesn't exist. Bill -- buildsys mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/buildsys
