On 07/03/2014 09:15 AM, Dennis Gilmore wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Wed, 2 Jul 2014 15:45:50 -0500
Pat Riehecky <[email protected]> wrote:
On 07/02/2014 02:40 PM, Dennis Gilmore wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Wed, 2 Jul 2014 11:21:13 -0500
Pat Riehecky <[email protected]> wrote:
On 07/02/2014 11:11 AM, Pat Riehecky wrote:
From: Pat Riehecky <[email protected]>
Over at the CentOS project they are looking into an rpkg based
tool, but due to the hard coded filename for external sourecs, a
lot of code is duplicated.
The attached patch preserves the existing behavior, but allows a
hook into the 'sources' function so that other metadata files can
be consulted.
The format of the url in the CentOS structure is also different.
However, I've not (yet?) taken a stab at making that customizable.
Pat Riehecky (2):
Allow custom 'sources' metadata file
Added optional 'valsep' for metadata files not seperated by
''
src/pyrpkg/__init__.py | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
For the custom url format, would a config entry or optional arg to
Commands.sources be preferred?
Pat
what kind of custom url format are you looking at? the url format
today is what koji needs.
Dennis
The 'sha summed source file(s)' for git.centos.org is hosted under
the following pattern:
https://git.centos.org/sources/<packagename>/<branch>/<shasum>
Whereas rpkg's expects (from line 1489 of __init__.py):
https://git.centos.org/sources/<packagename>/<filename>/<shasum>/<filename>
For example, when using the default URL path rpkg attempts to
download the following file:
https://git.centos.org/sources/a2ps/SOURCES/a2ps-4.14.tar.gz/365abbbe4b7128bf70dad16d06e23c5701874852/SOURCES/a2ps-4.14.tar.gz
The path I wish to set for rpkg to use is:
https://git.centos.org/sources/a2ps/c7/365abbbe4b7128bf70dad16d06e23c5701874852
ewww, seriously eww. the tooling would need to rename the file it gets
to the name in the spec file. this I think doesn't belong in rpkg,
whatever tooling centos people come up with will have to replace rpkgs
function with its own version. I would strongly advocate for centos to
rethink how they are doing it and follow the standard convention.
That kind of change is outside of my purview.
Pat
--
Pat Riehecky
Scientific Linux developer
http://www.scientificlinux.org/
--
buildsys mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/buildsys
