On Saturday 14 July 2007 21:21, Natanael Copa wrote: > Denis, > > Maybe you missed this while you were away so I send again. > > Adduser fails to create the user when ENABLE_FEATURE_CLEAN_UP is > disabled. > > The reason is that adduser will exec passwd without first flushing the > previously written /etc/passwd (and /etc/shadow). passwd will fail > because the user does not exist until files are flushed. But the flush > never comes because the buffered file handles are lost in the exec > operation. > > Attatched patch fixes this by flushing all file handles before exiting. > > Alternative fix would be to close the files regardless FEATURE_CLEAN_UP > but we save a few bytes with one fflush(NULL) over 2 fclose() (in case > shadow passwords are enabled) > > Please add this to 1.6.1 fixes.
Applied to svn and added to 1.6.1 hot fixes directory. Thanks. -- vda _______________________________________________ busybox mailing list [email protected] http://busybox.net/cgi-bin/mailman/listinfo/busybox
