Hi. Thanks for update.
On Fri, 20 Jul 2007 20:44:17 +0100
Denis Vlasenko wrote:
> On Friday 20 July 2007 05:29, Yuichi Nakamura wrote:
> > Attached is updated patch.
>
> I changed it a bit, see attached. Can you clarify this part?
>
> ret = lsetfilecon(my_file, newcon);
> if (ret) {
> bb_perror_msg("lsetfileconon(%s,%s)", my_file, newcon);
> goto out;
> }
>
> err:
> retval--;
> out:
> freecon(context);
> freecon(newcon);
> free(my_file_orig);
> return retval;
> }
>
> Looks like if lsetfilecon fails, we return success - ?!
> Is it really right?
Sorry, "goto err" is correct.
Fixed.
And I have fixed trivial compile errors.
I add following in Config.in for setfiles.
> Notice: If you built libselinux with -D_FILE_OFFSET_BITS=64,
> (It is default in libselinux's Makefile), you _must_ enable
> CONFIG_LFS.
In matchpathcon_filespec_add in setfiles.c,
"ino_t" is passed as first argument.
However, the size of ino_t depends on value of FILE_OFFSET_BITS.
It is set as "64" in libselinux's Makefile.
So, CONFIG_LFS(FILE_OFFSET_BITS=64 is set by this)
should be enabled for such case.
Regards,
--
Yuichi Nakamura
Hitachi Software Engineering Co., Ltd.
Japan SELinux Users Group(JSELUG): http://www.selinux.gr.jp/
SELinux Policy Editor: http://seedit.sourceforge.net/
setfiles.4.patch
Description: Binary data
_______________________________________________ busybox mailing list [email protected] http://busybox.net/cgi-bin/mailman/listinfo/busybox
