On Monday 10 September 2007 13:42, Denys Vlasenko wrote:
> I don't understand in full what is the intent of the above
> #if/#endif block. IIRC these are equivalent:
> execve(shell, (char **) args, environ);
> execv(shell, (char **) args);
> Can it be rewritten this way?
>
> #if ENABLE_SELINUX
> if (current_sid && !setexeccon(current_sid))
> freecon(current_sid);
> #endif
> execv(shell, (char **) args);
>
> If not, we need to add a comment which explains why not.
and, moreover, is freecon() needed at all? Maybe this is in order?
if (ENABLE_FEATURE_CLEAN_UP)
freecon(...)
--
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
