2007/9/28, Bernhard Fischer <[EMAIL PROTECTED]>:
> On Fri, Sep 28, 2007 at 05:51:34PM +0200, Loïc Grenié wrote:
>===================================================================
> >--- include/libbb.h    (r??vision 20077)
> >+++ include/libbb.h    (copie de travail)
> >@@ -259,8 +259,9 @@
> > char *xmalloc_readlink(const char *path);
> > char *xmalloc_readlink_or_warn(const char *path);
> > char *xrealloc_getcwd_or_warn(char *cwd);
> >+/* Free pointer if non NULL */
> >+void xfree(void *ptr);
> >
> >-
> > //TODO: signal(sid, f) is the same? then why?
> > extern void sig_catch(int,void (*)(int));
> > //#define sig_ignore(s) (sig_catch((s), SIG_IGN))
> >@@ -787,6 +788,7 @@
> >
> > int get_signum(const char *name);
> > const char *get_signame(int number);
> >+void print_signames_and_exit(void);
>
> This can be noreturn

    I've changed it. gcc adds 24 bytes with noreturn:

cognac% ./scripts/bloat-o-meter busybox_unstripped busybox_unstripped-noreturn
function                                             old     new   delta
kill_main                                            765     794     +29
pgrep_main                                           622     617      -5
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/1 up/down: 29/-5)              Total: 24 bytes

> That said, what's wrong about aliasing pkill to something like
> kill -9 $(pidof $it)
>
> same for pgrep:
> ps | grep $it | grep -v grep | awk '{print $1}'

    pgrep/pkill have pattern matching and fancy options.

        Loïc
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox

Reply via email to