On Nov 13, 2007 2:56 PM, Ralf Friedl <[EMAIL PROTECTED]> wrote: > Fernando Silveira wrote: > > Yep, but the patch follows inline. The read(2) return value was being > > stored in an unsigned variable, avoiding the error detection. I also > > added an error message, which wasn't implemented. > > Maybe tr should not exit in this case with EXIT_SUCCESS, but return an > error? Especially as tr is most of the time used in shell scripts, where > the return code is more likely to be noticed than an error message. > > GNU tr returns 1: > $ tr a b < /tmp; echo $? > tr: read error: Is a directory > 1
I agree. Patch is attached. -- Fernando Silveira <[EMAIL PROTECTED]>
busybox-1.8.1-tr_exit_failure.patch
Description: Binary data
_______________________________________________ busybox mailing list [email protected] http://busybox.net/cgi-bin/mailman/listinfo/busybox
