On Saturday 28 June 2008 12:23, [EMAIL PROTECTED] wrote: > Here comes the second part of compatibility patch for sendmail. > > Got rid of -U -P. Instead to authenticate we will use standard url notation: > [user:[EMAIL PROTECTED]:port]. M.b. make a libbb func for that? wget will use > it. > > Renamed -n to -N, -X to -S: -n and -X seems to be used in full-blown MTAs. > > Since BB sendmail became compatible, there is no need in #ifdefs in crond.c. > > Denys, please, apply. > Natanael, please, do stress test it.
0. CC: [email protected], otherwise Natanael won't get it. 1. opt_connect = "127.0.0.1"; } // fetch username and password, if any opt_connect = parse_url(opt_connect, &opt_user, &opt_pass); networking/sendmail.c: In function 'sendgetmail_main': networking/sendmail.c:352: error: passing argument 1 of 'parse_url' discards qualifiers from pointer target type make[1]: *** [networking/sendmail.o] Error 1 And it's not trivial. The reason why it is safe is not obvious. I am making necessary modifications. 2. Why do you guard against empty username or password in parse_url()? "" password is a valid thing to have: "user:@host". Patch is applied. -- vda _______________________________________________ busybox mailing list [email protected] http://busybox.net/cgi-bin/mailman/listinfo/busybox
