On Monday 07 March 2011 00:11:28 Denys Vlasenko wrote:
> On Sunday 06 March 2011 19:22, Dudy Kohen wrote:
> > In your suggestion you made some assumptions that are not applicable for
> > Android:
> > Android does not have an /etc/passwd file.
>
> Where did I made an assumption that this file must exist?
Hi,
It was not about a assumption but just about android
beeing very non-standard about this uid/gid/passwd
stuff as it has an exotic security model.
If we try to be portable to android i fear that
we will open a can of worms.
One example I recall about struct passwd
was dropbear allowing unrestricted
root access on android as pw->pw_passwd
is missing.
>
> > > ./util-linux/script.c- }
> > > ./util-linux/script.c- shell = getenv("SHELL");
> > > ./util-linux/script.c- if (shell == NULL) {
> > > ./util-linux/script.c: shell = DEFAULT_SHELL;
> > > --
> > >
> > > Should we try to retrieve current user's shell
> > (getpwuid(getuid())->pw_shell)
> > > before falling back to DEFAULT_SHELL?
>
> I do hope getpwuid(getuid()) on android returns valid struct passwd*?
>
See above.
My opinion is that if they want to use busybox on android
they should add the missing pieces to make their system
more standard compliant.
Ciao,
Tito
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox
