On Wednesday 23 March 2011 16:50, Peter Korsgaard wrote: > >>>>> "Denys" == Denys Vlasenko <[email protected]> writes: > > Hi, > > >> Hi, folks. I'm having a problem with busybox on FreeBSD: it segfaults > >> when I run something like this: > >> > >> $ busybox wget http://1.2.3.4 > >> > >> The reason for this is line 288 of ibbb/xconnect.c: result is freed > >> there, but if the address is numeric, it will contain NULL, hence > >> the segfault. > >> > >> In short, the trivial fix is attached (if the attachment doesn't > >> get through, it simply prefixes the freeaddinfo call with a > >> conditional on result). > > Denys> Applied, thanks! > > Please put it on http://busybox.net/downloads/fixes-1.18.4/ as well. > > On both glibc and uclibc, freeaddrinfo(NULL) is safe, but I don't see > any explicit requirements for it in the spec: > > http://pubs.opengroup.org/onlinepubs/009695399/functions/getaddrinfo.html
This isn't a regression. Can't it wait for 1.19.x? -- vda _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
