I see this recently changed in shell/hush.c:

-# if defined MAX_HISTORY && MAX_HISTORY > 0 && ENABLE_HUSH_SAVEHISTORY
+# if MAX_HISTORY > 0 && ENABLE_HUSH_SAVEHISTORY

Is it guaranteed that MAX_HISTORY is always defined?

Is it desired that compilation fails if it undefined?

If not, the warning-free answer to combine the defined and relation
would be:

#if MAX_HISTORY + 0 > 0 && ENABLE_HUSH_SAVEHISTORY

The + 0 makes sure that the expression is valid and compiles even if
MAX_HISTORY is blank.
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox

Reply via email to