On Fri, Aug 15, 2014 at 1:31 PM, Denys Vlasenko <vda.li...@googlemail.com>
wrote:
> On Wed, Aug 13, 2014 at 2:25 PM, Laszlo Papp <lp...@kde.org> wrote:
> > On Wed, Aug 13, 2014 at 12:54 PM, tito <farmat...@tiscali.it> wrote:
> >> On Wednesday 13 August 2014 12:13:10 Laszlo Papp wrote:
> >> > On Wed, Aug 13, 2014 at 9:52 AM, Laszlo Papp <lp...@kde.org> wrote:
> >> >
> >> > > commit 55d6582d88470078cef09f52d1bc3c9c3f7fca6a
> >> > > Author: Laszlo Papp <lp...@kde.org>
> >> > > Date: Wed Aug 13 09:48:08 2014 +0100
> >> > >
> >> > > Fix the addgroup help output
> >> > >
> >> > > Since the applet has two options, it is quite misleading to only
> >> > > mention one in
> >> > > the usage example. It should either use OPTIONS there or
> enumerate
> >> > > the
> >> > > possible
> >> > > options. The latter seems to be more common in applet, so I
> picked
> >> > > that one.
> >> > >
> >> > > diff --git a/loginutils/addgroup.c b/loginutils/addgroup.c
> >> > > index 22cd0e6..ce57459 100644
> >> > > --- a/loginutils/addgroup.c
> >> > > +++ b/loginutils/addgroup.c
> >> > > @@ -11,7 +11,7 @@
> >> > > */
> >> > >
> >> > > //usage:#define addgroup_trivial_usage
> >> > > -//usage: "[-g GID] " IF_FEATURE_ADDUSER_TO_GROUP("[USER] ")
> >> > > "GROUP"
> >> > > +//usage: "[-gS] " IF_FEATURE_ADDUSER_TO_GROUP("[USER] ")
> >> > > "GROUP"
> >> > > //usage:#define addgroup_full_usage "\n\n"
> >> > > //usage: "Add a group " IF_FEATURE_ADDUSER_TO_GROUP("or add a
> >> > > user
> >> > > to a group") "\n"
> >> > > //usage: "\n -g GID Group id"
> >> > >
> >> >
> >> > Hmm, actually, I got some doubts whether this change is useful because
> >> > while it fixes one issue, the applets seem randomly inconsistent, e.g.
> >> > this
> >> > is not holding any consistency with any other either:
> >> >
> >> > Usage: crond -fbS -l N -d N -L LOGFILE -c DIR
> >> >
> >> > At best, it is missing the brackets, but the applets are inconsistent
> at
> >> > large overall, sadly, so I am not sure it is any improvement to fix
> this
> >> > one on its own, and fixing all would be more intrusive than I care.
> >> >
> >> Hi,
> >> maybe is more easy to understand as it shows which option needs
> >> a argument.
> >>
> >> +//usage: "[-g GID][-S] " IF_FEATURE_ADDUSER_TO_GROUP("[USER] ")
> >> "GROUP"
> >>
> >
> > Well, it is all about personal preferences, so whatever Denys wishes as
> the
> > maintainer, but the more important objective issue is outlined above.
>
> I fixed help text by adding "[-S]".
>
> > Why
> > applets are doing this on their own is beyond my league other than
> > hysterical raisins...
>
> I didn't understand this part.
> Why applets are doing /what/ on their own?
>
As mentioned in the thread above, applets are defining the help display
text on their own, and it is different for different applets. There is no
centralized common solution to this problem. Every little applet is doing
its own way as they wish.
Also, it will be difficult to change at many places if you happen to need
to.. centralization would rock here imho.
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
