On Tue, Aug 19, 2014 at 7:24 AM, Natanael Copa <[email protected]> wrote:
> On Mon, 18 Aug 2014 00:11:10 -0300 > Guilherme Maciel Ferreira <[email protected]> wrote: > > > The test suite scripts fail with "Bad substitution" error when using a > shell > > other than Bash. This patch adds an alert to the user, to remind him to > change > > its /bin/sh symlink. > > Wouldn't it be better to do: > Or even eliminate the bashism? > diff --git a/testsuite/runtest b/testsuite/runtest > index 51575d9..35968b1 100755 > --- a/testsuite/runtest > +++ b/testsuite/runtest > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # Usage: > # runtest [applet1] [applet2...] > > > Or even better, fix the script to be posix compliant? > Yep, exactly... +1 to this.
_______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
