Hello Isaac, I will repost the patches later on (most likely today), as well as reimplement the arpping to use commandline arguments.
The compile time option is a bit quirky, I agree. Kind regards, Michel Stam -----Original Message----- From: Isaac Dunham [mailto:[email protected]] Sent: Tuesday, October 07, 2014 18:08 PM To: Stam, Michel [FINT] Cc: [email protected] Subject: Re: busybox patches On Tue, Oct 07, 2014 at 02:37:11PM +0200, Stam, Michel [FINT] wrote: > Dear list, > > About a week ago I posted 3 patches on bugzilla; > https://bugs.busybox.net/show_bug.cgi?id=7490 > https://bugs.busybox.net/show_bug.cgi?id=7496 > https://bugs.busybox.net/show_bug.cgi?id=7502 > > Would anyone have time to take a look at these patches? Or should I > post them here? > > Kind regards, > Michel Stam For "feature enhancements" like these, please post patches to the list. Now, some comments: I'm wondering why the first one made arpping timeout a *compile-time* constant as well as allowing to disable it altogether; this would seem to be a site-specific setting rather than a distributor-specific one. Rebuilding busybox because you have a different timeout could be painful, depending on the build/deployment environment. If you want to make it variable, why not add a compile-time switch to enable setting the arpping timeout? It should have the same default, and it could allow 0 to disable it. Hope this helps, Isaac Dunham _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
