On Wed, Jul 20, 2016 at 02:56:40PM -0700, Jeremy Chadwick wrote:
> +static int is_ip_address(const char *string)
> ...
> + if (ENABLE_FEATURE_IPV6 && result != 0) {
Minor issue: the "result != 0" comparison is wrong (inverted). It
could, if an IP address was passed, and IPV6 is enabled, cause an
additional (extraneous) call to inet_pton(). The line should read:
+ if (ENABLE_FEATURE_IPV6 && result == 0) {
I always find *something* after I post patches publicly, despite
testing. Sorry about that. :/
--
| Jeremy Chadwick [email protected] |
| UNIX Systems Administrator http://jdc.koitsu.org/ |
| Making life hard for others since 1977. PGP 4BD6C0CB |
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox
