Hi Metin Kaya, On Mon, Jul 25, 2016 at 10:38:08AM +0300, Metin Kaya wrote: > I did not get what is wrong. Even the previous version of the patch works > fine.
The problem is that the 'do_mkvol' macro, for example, must evaluate to true if, and only if, the applet name is "ubimkvol". With this patch, 'do_mkvol' is incorrectly also true when the applet name is "ubimkblock". baruch > On Mon, Jul 25, 2016 at 10:34 AM, Baruch Siach <[email protected]> wrote: > > On Mon, Jul 25, 2016 at 10:28:32AM +0300, Metin Kaya wrote: > > > @@ -68,6 +86,8 @@ > > > > > > #define do_attach (ENABLE_UBIATTACH && applet_name[3] == 'a') > > > #define do_detach (ENABLE_UBIDETACH && applet_name[3] == 'd') > > > +#define do_mkblock (ENABLE_UBIMKBLOCK && applet_name[3] == 'm' && > > applet_name[5] == 'b') > > > +#define do_rmblock (ENABLE_UBIRMBLOCK && applet_name[3] == 'r' && > > applet_name[5] == 'b') > > > #define do_mkvol (ENABLE_UBIMKVOL && applet_name[3] == 'm') > > > #define do_rmvol (ENABLE_UBIRMVOL && applet_name[4] == 'm') > > > > These checks incorrectly match ubimkblock and ubirmblock still. > > > > baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - [email protected] - tel: +972.52.368.4656, http://www.tkos.co.il - _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
