On 08/27/2016 09:39 AM, Michael Conrad wrote:
On 8/27/2016 2:18 AM, Cristian Ionescu-Idbohrn wrote:
On Sat, 27 Aug 2016, Denys Vlasenko wrote:
config BUSYBOX
         bool "Include busybox applet"
         default y
         help
           The busybox applet provides general help regarding busybox
and
           allows the included applets to be listed.  It's also required
           if applet links are to be installed at runtime.

           If you can live without these features disabling this will
save
           some space.
And this is also expected:

    $ ./busybox
    busybox: applet not found

when executed immediately after build?  And this too?

    $ ./busybox --help
    -help: applet not found

    $ ./busybox --list
    -list: applet not found


Yes, adding or removing those behaviors is precisely the purpose of the
CONFIG_BUSYBOX setting.

Maybe you should explain your situation and what you expected? because a
person reading your subject line would assume you are trying to say "I
compiled busybox without the CONFIG_BUSYBOX flag, and now I'm surprised
that it did what it said it would do"..._

Hi to all,
what busybox does with this option looks a little puzzling to me
and not coherent to what is written in the option's help text in all
of the 3 cases shown above:

>>
>>     $ ./busybox
>>     busybox: applet not found

The help text and applet list should not be shown and no error thrown
as this is the expected behavior so it should be:

>>     $ ./busybox
>>     $ echo $?
>>     0

In this other 2 cases the error messages are completely
broken and non-sense as they misrepresent the long name option
which is not correctly parsed as the applet name

>>     $ ./busybox --help
>>     -help: applet not found
>>
>>     $ ./busybox --list
>>     -list: applet not found

The expected behavior should be something like this

>>     $ ./busybox --list
>>     --list: unknown option
>>     $ echo $?
>>     1

or following what was the busybox standard until now
print the usage text of the applet (or busybox), but
as we have none to print.....

So it seems to me that this patch could be improved.

Ciao,
Tito



_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

Reply via email to