On Wed, Jan 4, 2017 at 7:01 PM, Denys Vlasenko <vda.li...@googlemail.com> wrote:
> With this patch, if I answer "no" to ASH, then all ash config options
> _are skipped_, and then I can specify that "sh" is ash.
> But I can't configure ash features, since they are skipped already
> (config system silently sets them to defaults).
>
> This problem did not exist before the patch.

I have tested with "make oldconfig", and once the SH_IS_ASH is enabled,
"make oldconfig" will eventually restart and prompt for options that were
previously skipped. So ash options _can_ be configured. There was no such
problem you described.

> Your mail agent mangles the patch (tabs->spaces).

Oops. Didn't notice Google Mail did that. I'm resending the patch as
attachment instead.
From 30f4060de0f09cbcbefca461ca3b176eb618c3b0 Mon Sep 17 00:00:00 2001
From: Explorer09 <explore...@gmail.com>
Date: Sun, 25 Dec 2016 08:32:37 +0800
Subject: [PATCH] Fix allnoconfig that ash is built in by default.

Change the config order that SH_IS_* and BASH_IS_* will be prompted
after ASH and HUSH. And if CONFIG_ASH=n, SH_IS_* choice will default to
SH_IS_NONE.

Signed-off-by: Kang-Che Sung <explore...@gmail.com>
---
 shell/Config.src | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/shell/Config.src b/shell/Config.src
index 7f5f67050..794f9985a 100644
--- a/shell/Config.src
+++ b/shell/Config.src
@@ -5,10 +5,12 @@
 
 menu "Shells"
 
+INSERT
 
 choice
 	prompt "Choose which shell is aliased to 'sh' name"
-	default SH_IS_ASH
+	default SH_IS_ASH if ASH
+	default SH_IS_NONE
 	help
 	  Choose which shell you want to be executed by 'sh' alias.
 	  The ash shell is the most bash compatible and full featured one.
@@ -55,10 +57,6 @@ config BASH_IS_NONE
 
 endchoice
 
-
-INSERT
-
-
 config FEATURE_SH_MATH
 	bool "POSIX math support"
 	default y
-- 
2.11.0

_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

Reply via email to