It seems that BusyBox v1.27.2 doesn't load history from a history file when ENABLE_FEATURE_EDITING_SAVEHISTORY is not set.

I think that the corresponding source code logic is here:
<https://git.busybox.net/busybox/tree/shell/ash.c#n13950>

Such logic doesn't match the feature name, which is ...SAVEHISTORY and not ...LOADHISTORY.

For example:
Busybox is often used in (emergency/disaster) recovery environments. There is no need for any saving (readonly media). However it comes handy when frequently used commands can be pre-loaded into the initramfs (for interactive logins).

Is such a loadhistory-without-savehistory scenario tackled when changing:

#if MAX_HISTORY > 0 && ENABLE_FEATURE_EDITING_SAVEHISTORY

to

#if MAX_HISTORY > 0

in ash.c?

In case it is not, what more to change to allow loading a HISTFILE when ENABLE_FEATURE_EDITING_SAVEHISTORY is not set?

Is such a change a candidate for an upstream patch?
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

Reply via email to