> How about > > 72 (add/remove: 3/0 grow/shrink: 2/0 up/down: 328/0) Total bytes: 328 > > to keep the numbers aligned?
Yes! 72 is totally aligned with function/old/new/delta length! :) And IMHO 75 columns is still a bit preferred than 72 columns, two reasons are considered: 1. consistent with linux kernel upstream. Found this thread had a v1 proposal patch to do line wrapped at 72 columns: https://lore.kernel.org/lkml/1427827225.18175.3.ca...@perches.com/T/#u and finally 75 columns goes to upstream, Commit 2a076f40d8c9b ("checkpatch, SubmittingPatches: suggest line wrapping commit messages at 75 columns"): https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=2a076f40d8c9b 2. easy to maintain and grep keyword '75'. 75-columns patch uses 's/78/75; s/80/77/' replacement and keeps keyword '75' in the file, if someday wide screen is very popular and output width exceeded that said 100 columns would not ruin people's life, we could easily find the expected length '75' and replace it with a wider numbers. 72-columns patch uses 's/78/72; s/80/74/' replacement might a bit hard to find the expected length afterward. By the way, loop is not required in my previous length counting script :) simply pipe to awk is fine: ~/busybox/scripts/bloat-o-meter ~/busybox_unstripped_{orig,fix} \ | awk '{ print length, $0 }' -- Regards, Jones Syue | 薛懷宗 QNAP Systems, Inc. _______________________________________________ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
