Hi! Thank you all for you thorough reviews.
This new revision of the patchset contains the following changes: 1. Some patch reordering 2. All calls to BB_EXECVP are now supposed to be safe* 3. Fixed some overlooked problems, like execv in httpd and popredir in ash. I am keen to hear your opinions! * - I think I will add some code to BB_EXECVPE to duplicate the argv[], since someday someone will forget about this and try to modify the passed arguments. I'd rather have some cleaner code and this generic safety, then have to manually write the ugly code which creates argv[]s on the stack. What do you think? Best regards, Nadav _______________________________________________ busybox mailing list [email protected] https://lists.busybox.net/mailman/listinfo/busybox
