On Fri, Sep 27, 2024 at 11:48 AM Laurent Bercot
<[email protected]> wrote:
> Several small improvements to udhcpc6.
>
> - Remove usage text for the nonexistent -B option.
> - Fix a segfault when renewing an IA_PD lease without IA_NA (which means
> the client hasn't been assigned an ip, so we cannot locally bind to it).
> - Fix NAK management: check the option length, and print the status code
> and status message


> - Print the text of short IA_PD options, which may contain useful
> information

IA_PD does not contain text, so

>                                         if (client6_data.ia_pd->len < (4 + 4 
> + 4) + (2 + 2 + 4 + 4 + 1 + 16)) {
> -                                               bb_info_msg("%s option is too 
> short:%d bytes",
> -                                                       "IA_PD", 
> client6_data.ia_pd->len);
> +                                               bb_info_msg("%s option is too 
> short: %d bytes: %.*s",
> +                                                       "IA_PD", 
> client6_data.ia_pd->len,
> +                                                        
> client6_data.ia_pd->len, client6_data.ia_pd->data);

the above is not correct, so I am not making this change (yet?).
(As far as I understand, IA_PD can carry STATUS_CODE sub-option
in its "IA_PD-options":
   """The status of any operations involving this IA_PD is indicated in a
   Status Code option in the IA_PD-options field."""
and *it* can have a textual error message.
Is it what you are seeing on your hardware?
)


> - Add a -m option to always send renew requests as multicast.
>
>  These last two changes are useful to deal with hopelessly broken DHCPv6
> servers such as the one from the Orange Livebox (one of the main French
> ISPs) which I'm currently having the displeasure to have to talk to,
> hence the patch.

Applying the rest.
_______________________________________________
busybox mailing list
[email protected]
https://lists.busybox.net/mailman/listinfo/busybox

Reply via email to