[ 
https://issues.apache.org/jira/browse/BVAL-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172093#comment-13172093
 ] 

Roman Stumm commented on BVAL-68:
---------------------------------

Hi Matt, thanks for the changes, seems that some "real" bugs have been fixed 
(in ValidateMethodInterceptor).

But don't you think, that the overhead for cloning the arrays in methods that 
are called VERY often is worth the security, like:
FeaturesCapable.getValidations()
MetaBeanBuilder.getFactories()
and
MetaBean.getProperties() 

I once implemented these methods as arrays instead of lists for performance and 
garbage reasons. Did these changes affect our benchmarks?
                
> Use FindBugs to reduce coding errors
> ------------------------------------
>
>                 Key: BVAL-68
>                 URL: https://issues.apache.org/jira/browse/BVAL-68
>             Project: BeanValidation
>          Issue Type: Improvement
>          Components: build, jsr303
>    Affects Versions: 0.1-incubating
>            Reporter: Donald Woods
>             Fix For: 0.4-incubating
>
>
> Use FindBugs http://findbugs.sourceforge.net/  and the maven plugin for it to 
> reduce coding errors.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to