It looks like it was organized before by function, and you want to organize it by type instead. I'm not familiar enough with the code to say whether this is an improvement.

It was one class per file, and using GtkDialog you have 2 methods per
class in principle.. __init__ and _on_button_clicked

I did notice two issues, though...

First, there are a lot of "+" lines where you added new dialogs, but no "-" lines to remove the old dialogs. The old ones should be removed.

I didn't remove the old files yet as it is still work in progress. When
all dialogs are in olivedialogs, all the files can be deleted and part
of the glade file.


The other issue is in these lines:

-        from remove import OliveRemoveDialog
+        from olivedialogs import RemoveDialog
         remove = OliveRemoveDialog(self.wt, self.wtpath,

Looks like a bug to me.

Well spotted, should be 'remove = RemoveDialog' of course.

Thanks for the comments

Jasper


Attachment: signature.asc
Description: PGP signature

Attachment: signature.asc
Description: OpenPGP digital signature

-- 
bzr-gtk mailing list
[email protected]
Modify settings or unsubscribe at: 
https://lists.canonical.com/mailman/listinfo/bzr-gtk

Reply via email to