Ok, in my noglade branch I moved the ListStore/TreeStore generator code from _load_left/right to the OliveGui class. This leaves the _load_* functions pretty much equal to the refresh_* functions so I deleted the _load_* functions in my branch. - Oh and I applied the patch I send in with the self.acceptable_errors var. - Changed the Bookmark TreeStore to a ListStore to remove the whitespace on the left - Bunch of little tweaks. So besides the info_dialog Olive functions great without Glade. :)
Jasper Scott Scriven wrote:
* Jasper Groenewegen <[EMAIL PROTECTED]> wrote:You mean like this? :) And now I _will_ go to bed.This seems fine for the purposes of this patch, but after looking a little closer I see something else which should be fixed... and this is what was bugging me initially. I had a hunch I'd find something like this:In olive/__init__.py, the _load_right() function and refresh_right() function should probably have a bunch of common code merged together. They each have over 100 lines in common, and that's a lot of duplication.Everything in _load_right() from "dirs = []" to "liststore.append([gtk.STOCK_FILE, ... ])" seems redundant. So, about 104 lines in can probably be replaced by a call to self.refresh_right(), after resolving the minor differences between the two.To see the differences, I just saved each function to its own file, removed one level of indentation from load_right(), and viewed both in "meld".Does this look like something you'd be willing to fix? If not, I might try it.-- Scott
signature.asc
Description: PGP signature
signature.asc
Description: OpenPGP digital signature
-- bzr-gtk mailing list [email protected] Modify settings or unsubscribe at: https://lists.canonical.com/mailman/listinfo/bzr-gtk
