Re: Bug...

Tue, 29 Jul 2008 01:52:50 -0700

Since I don't have a repo of that kind around to test stuff, could you try to replace the gtk.Label('%s') with gtk.Label("""%s""") on line 257 in bzr-gtk/olive/info.py? I hope that solves the crash and I'll patch it against trunk if it does. But maybe it introduces an ugly line break in the resulting info window so other measures may be necessary. If it doesn't fix it I'll have to do some string checking in other places. :( 

Jasper

Russel Winder wrote:

On Mon, 2008-07-28 at 22:25 +0200, Jasper Groenewegen wrote:
Hmm that line is part of an iterator that constructs all gtk.Labels in the info dialog. And for me it works like a charm so for now I presume the fault is in the description string. 
That string is obtained as

repository._format.get_format_description()

Do you happen to know if 'Packs containing knits with rich root
support' is the full string that should be returned by a bzrlib repository object? It's a workingtree.branch.repository._format.get_format_description() to be precise. 
Currently it just parses the description string in the label as

"exec gtk.Label('%s')"%descriptionstring

which goes well, except if the string has quotation marks as well I guess..


Uuuurrr... pass on all points.  I am just a user ;-)

What I can say is that the string "Packs containing knits with rich
root" appears in bzrlib/repofmt/pack_repo.py and is terminated with a
\n.  I therefore conclude that somewhere along the line the \n is being
incorrectly interpreted.

Attachment: signature.asc
Description: OpenPGP digital signature

-- 
bzr-gtk mailing list
[email protected]
Modify settings or unsubscribe at: 
https://lists.canonical.com/mailman/listinfo/bzr-gtk

Reply via email to