Delay registration of signals to prevent problems when signal handlers use not yet constructed widgets. This should make the initialisation of the viz window a bit more robust (and it's actually required to prevent a backtrace when using "bzr viz" on svn branches).
Cheers, Jelmer --
# Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: [EMAIL PROTECTED] # target_branch: lp:bzr-gtk # testament_sha1: 90ec411f873703ce8814abcfc5fa24e8c86719b9 # timestamp: 2008-11-28 17:43:09 +0100 # source_branch: http://people.samba.org/bzr/jelmer/bzr-gtk/trunk # base_revision_id: [EMAIL PROTECTED] # # Begin patch === modified file 'viz/branchwin.py' --- viz/branchwin.py 2008-08-04 10:40:07 +0000 +++ viz/branchwin.py 2008-11-28 16:42:25 +0000 @@ -125,6 +125,12 @@ vbox.pack_start(self.paned, expand=True, fill=True) vbox.set_focus_child(self.paned) + self.treeview.connect('revision-selected', + self._treeselection_changed_cb) + self.treeview.connect('revision-activated', + self._tree_revision_activated) + + self.treeview.connect('tag-added', lambda w, t, r: self._update_tags()) vbox.show() def construct_menubar(self): @@ -289,13 +295,6 @@ self.treeview = TreeView(self.branch, self.start_revs, self.maxnum, self.compact_view) - self.treeview.connect('revision-selected', - self._treeselection_changed_cb) - self.treeview.connect('revision-activated', - self._tree_revision_activated) - - self.treeview.connect('tag-added', lambda w, t, r: self._update_tags()) - for col in ["revno", "date"]: option = self.config.get_user_option(col + '-column-visible') if option is not None: # Begin bundle IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWX4CKQEAAZ5fgAQUUef//1YQ AQC////wUAPMt4F3Guqdm3QkkmgmTVPap7CZNNJ5MqbU09T1D1DQbIJJTRpqeRNqaQB6Iepo9QDQ AGgyEaU9EyT1HqYTamRoyaBptTTQNBgAAAANAAAAAAkomEwhMaiamnpHqB6j1PUGQ9IGQKSsvc3b z6m6G2Wg26lWMntXHZA8LWDVc5poN/xQESK8No5q0RDfuHzB0FSrT1pjaMuM5+t9XLhvbPBXwTa6 iUoXoNeBowA+hemGefLtXNVdZB4pm8iVy42IHDRWdpxGh78/1xj9FJ7aFZ4nEc1g63cL+P0psh8l OsEiNQKwuguw2ozvSk1E1ewjI4RmurH5VjqxnsIcV3mWOyxFSPqmgYQkoDBQ9uwxH+AxZQNxAavu Zl8cBdhxPpzkygSPLkLspFYIWhjvNwtBzhos2Fy23rQ+Lh7WioMC000oXllGrNsIMJVbe+JcO31L rGxTuLbxo24XRaGZi9jlcaEwvJGs7ZGIpMqZNQ3BTV452bU03tIEDWxN7SLzAYBK4/6yWSHmow/q lM3S1JvvM1wFUkxVFldTBxVIcLKmBLKLYrM8jCgZh0Hmh5E/tRE4hdeuZZnvZMTVMCQVZD2OlAd6 CjlpCuKmFo1oeziNnizqHRWkSFpQoPup0PKSZo2WtwOaXprhH6KPmkRBSYm4jMyIyt4MrefdpOJR tLgdiq/k0KRk4hiCo2Ti5qzwRauc9RqUiRQZDvM0HWDz1xNGl+eaGcTFyv9OIQEJv4ROW2DTNNFR YqGFZI0GkirSpYuuLUZrsLMGkPpIb3JzTobr8DJ13LVefc26jOZ4PgsM6SslUhjGrGl0zS9qwO9S RPHlFiYjWtsLkiflLtD0m6C56VcmJD1NQdwkKkqFYYGJeeRUOIic7ZZ4MvxyFUkYpQzUyj++svCj aflqwW/vFiY80RecVsKnbZPMYqgV67WvlFgmYJkjDB5A/CcsscDH+s+rHUcmtPUVvQVwTy9E5bBU 4UJjlwcKTq4E7yr6rFPSOzJ4KrDWX74rjXGAVApQgXCwOBABIZCzarInFJZkSQhDq0OHfqLuihdG hhFF4d6RNdLk+elS1rLN5AJXRIxGeAqqnUWu1hewFQOAQFxfAWFfE5Pxi1PmkUc5Okle4IE9h45X 17b4YmGbI8JFeEPg2eFcqCA4ohdmE4C4Eblywbo0Giy2QfwHVXa0ZoiV0CdOMMIuVgElpokalS77 m4iyvoNq15OxaUbYEYphLu2CqcmHwdfaDA05OmBZklTudRLED/i7kinChIPwEUgI
signature.asc
Description: Digital signature
-- bzr-gtk mailing list [email protected] Modify settings or unsubscribe at: https://lists.canonical.com/mailman/listinfo/bzr-gtk
