Vincent Ladeuil wrote: > The attached patch implements what we discussed on IRC: > > 1) Install a progress widget ASAP, > 2) Install a progress widget every time it's needed, > > 3) Uninstall the progress widget when it's destroyed (or its > container here) but not before. Thanks!
Given that we'll probably end up doing this in a couple more cases I think we could probably refactor this into a helper method: + if getattr(ui.ui_factory, "set_progress_bar_widget", None) is not None: + # We'are using our own ui, let's tell it to use our widget. + ui.ui_factory.set_progress_bar_widget(self.progress_widget) Although I guess we can also add that next time we add need to add a call to this in another place. I'm happy to see the patch land, with or without that bit refactored. bb:approve Cheers, Jelmer -- bzr-gtk mailing list [email protected] Modify settings or unsubscribe at: https://lists.canonical.com/mailman/listinfo/bzr-gtk
