On Sun, 2011-02-13 at 17:12 +0000, Max Bowsher wrote: > On 13/02/11 13:48, Jelmer Vernooij wrote: > >>>> 2) bzr-gtk uses a file called 'credits.pickle', which is generated by > >>>> bzr-stats. This needs to be done manually (by invoking 'setup.py > >>>> build_credits') when building a release tarball, and has been forgotten > >>>> twice in recent times: http://pad.lv/397526. Moreover, it means we can't > >>>> do a daily recipe build of bzr-gtk (because we can't run arbitrary extra > >>>> generation steps when building the source package, and we can't build > >>>> the credits.pickle when building the binary package) > >>>> > >>>> Proposal: Just check the credits.pickle into the branch. Modify the > >>>> releasing instructions to remind the release manager to manually update > >>>> the checked in copy where they would normally build one just for the > >>>> tarball. > >> > >>> Including credits.pickle in the branch seems reasonable, but why would > >>> we leave it until the release to do so? I'd rather just update > >>> credits.pickle every time we merge into trunk. > > I'll propose an update to HACKING for this. > > > > It might also be interesting to start running an instance of tarmac that > > can do this. > > Actually, now that we have a working recipe build, I'd favour leaving it > out - having a generated file there was better than broken builds, but > if we cover recipe builds via auto-generation, and release tarballs via > clearer documentation for the RM, then I'd rather avoid having a > binary(ish) file that won't merge well and just duplicates info from the > branch history. I still think it's a good idea to version it, also so we can drop the special casing when running directly from the branch.
Generating credits.pickle from the clean target is a really evil hack. I'd rather avoid it for the daily builds if we can, but if you must then please put the into a new branch, rather than the official Debian packaging branch. Cheers, Jelmer
signature.asc
Description: This is a digitally signed message part
-- bzr-gtk mailing list [email protected] Modify settings or unsubscribe at: https://lists.canonical.com/mailman/listinfo/bzr-gtk
