[ 
https://issues.apache.org/jira/browse/XERCESC-2004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14341137#comment-14341137
 ] 

Scott Cantor commented on XERCESC-2004:
---------------------------------------

Added to 3.1 branch, r1662873

> bit operation error in DOMNodeImpl::reverseTreeOrderBitPattern 
> ---------------------------------------------------------------
>
>                 Key: XERCESC-2004
>                 URL: https://issues.apache.org/jira/browse/XERCESC-2004
>             Project: Xerces-C++
>          Issue Type: Bug
>          Components: DOM
>    Affects Versions: 3.1.1
>         Environment: any
>            Reporter: 朱亚东
>            Assignee: Alberto Massari
>             Fix For: 3.1.2, 3.2.0
>
>
> code like below:
> short DOMNodeImpl::reverseTreeOrderBitPattern(short pattern) const {
>     if(pattern & DOMNode::DOCUMENT_POSITION_PRECEDING) {
>         pattern &= !DOMNode::DOCUMENT_POSITION_PRECEDING;
>         pattern |= DOMNode::DOCUMENT_POSITION_FOLLOWING;
>     }
> I think it should be:
> short DOMNodeImpl::reverseTreeOrderBitPattern(short pattern) const {
>     if(pattern & DOMNode::DOCUMENT_POSITION_PRECEDING) {
>         pattern &= ~DOMNode::DOCUMENT_POSITION_PRECEDING;
>         pattern |= DOMNode::DOCUMENT_POSITION_FOLLOWING;
>     }
> because !DOMNode::DOCUMENT_POSITION_PRECEDING always be 0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to