On 29/06/17 20:17, Cantor, Scott wrote:
On 6/29/17, 3:02 PM, "Roger Leigh" <[email protected]> wrote:

The recent trunk changes broke a few of the unit tests.

I don't understand how, other than the ones that are for some reason depending 
on the output of the parameter options for the DOMCount sample. That seems like 
an odd test, but it certainly would have broken.

Since nothing should be actually invoking the sample with the new option, I 
don't know why a new error would be raised in the tests, it defaults to 
behaving the same as before, allowing DTDs.

Do you need a hand looking at fixing any of these bits?

I don't know any of the tests or even how to run them, so probably.

If the tests can be run locally with an autotools build, I haven't found that 
trick yet.

It's "scripts/sanityTest.pl", a Perl script which runs all the tests, concatenates their output, and then diffs it with the expected output. It fails if the output differs or the tests fail prematurely.

or "ctest [-V]" for CMake, which is exactly the same, but runs the tests individually without concatenating the output (so you can run them individually).

You can run either. CTest is more flexible (you can run individual tests) and it tells you which specific tests failed. The Perl script just gives you a diff and you have to work out what failed yourself.

The DOMCount test is definitely just an output difference issue. But the others are exiting nonzero or segfaulting.



Regards,
Roger

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to