[ https://issues.apache.org/jira/browse/XERCESC-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16345346#comment-16345346 ]
Roger Leigh commented on XERCESC-2134: -------------------------------------- Looking more closely, the Windows builds in 3.1 were already using the InMemory message loader, so there weren't any users of this code. Looking more closely at it: static const char* const privDLLName = "IXUTIL"; fModHandle = ::GetModuleHandleA(privDLLName); it looks like this code wouldn't be functional in any case (there's no IXUTIL module, and it's not clear where the resources it would load come from–there's no remaining logic to generate them). Would anyone object to this old, unused and non-functional code being removed from the source repository? > CMake build missing support for Win32MsgLoader > ---------------------------------------------- > > Key: XERCESC-2134 > URL: https://issues.apache.org/jira/browse/XERCESC-2134 > Project: Xerces-C++ > Issue Type: Improvement > Components: Build > Affects Versions: 3.2.0 > Reporter: Roger Leigh > Assignee: Roger Leigh > Priority: Major > > The Win32MsgLoader wasn't present in the Makefile.am the CMakeLists.txt was > copied from, so all Windows builds are currently defaulting to the > InMemoryMsgLoader. This is an unintentional omission which is simple to > correct. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org