rleigh-codelibre commented on pull request #39: URL: https://github.com/apache/xerces-c/pull/39#issuecomment-926097632
I have read through all the changes, and everything looks sensible. Where you changed `retNode` to `specNode`, am I correct in the assumption that this was always buggy? If anyone else has time to look through, that would be appreciated. I'm certainly in favour of merging it, but given that this in some fairly complex code, it could certainly use a second or third opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org