johnjamesmccann commented on pull request #47: URL: https://github.com/apache/xerces-c/pull/47#issuecomment-1026872614
Ah yes I can see that now, thanks for picking up on that. Do I need to add that change to my fork or has it been added in your fork which is later than mine? Thanks and kind regards John From: Even Rouault ***@***.***> Sent: 25 January 2022 14:15 To: apache/xerces-c ***@***.***> Cc: McCann, John (DI SW PE OT IO PP) ***@***.***>; Mention ***@***.***> Subject: Re: [apache/xerces-c] [XERCESC-2188] Fix potential double-free in usage of ReaderMgr::pushReader() (PR #47) I cant see how my changes could cause a test regression, all my change does is delete 4 smart pointers that are not used in the code base. yes, but that causes a memory leak since nobody would take care of freeing the declDTD object. Hence my extra changes — Reply to this email directly, view it on GitHub<https://github.com/apache/xerces-c/pull/47#issuecomment-1021224266>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXMN5WGUPIVCZD6K2NQ2IYTUX2V5XANCNFSM5MTPEBCQ>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>> ----------------- Siemens Industry Software Limited is a limited company registered in England and Wales. Registered number: 3476850. Registered office: Pinehurst 2, Pinehurst Road, Farnborough, Hampshire, GU14 7BF. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
