--- In [email protected], "izecksohn" <izecks...@...> wrote: > > http://www.izecksohn.com/pedro/c/rebase/
Good effort. Some comments: 1. When you build it, some warnings are generated: $ make gcc -Wall rebase.c -o rebase rebase.c: In function `main': rebase.c:73: warning: format `%d' expects type `int', but argument 2 has type `time_t' rebase.c:111: warning: format `%u' expects type `unsigned int', but argument 5 has type `time_t' This doesn't look good - it would be better if you modified the code to prevent the warnings. 2. When you run it, it gives a warning/error: $ rebase Convert 64 decimal to base 25: 2e You took 15 seconds to calculate it right. I could not open rebase_stats.txt No such file or directory 3. Running make without a target (re-)builds the tar file as well as the executable - it should only build the executable. 4. The makefile clean target attempts to remove rebase.exe, which the makefile doesn't create. It also runs make, to rebuild everything. This isn't 'standard' clean behaviour. Use rm -f to prevent warnings if files don't exist eg. if you make clean twice. Also use PHONY (see http://www.gnu.org/software/make/manual/make.html ). Haven't looked at your code yet... :-)
