You are completely right. I would rather have a specific bug than a general guideline (even if it is correct) but I will keep this bug report as wishlist to serve as a reminder.
-- You received this bug notification because you are a member of C2C OERPScenario, which is subscribed to the OpenERP Project Group. https://bugs.launchpad.net/bugs/814620 Title: "if not <variable>" instead of "if <variable> is None" Status in OpenERP Server: Confirmed Bug description: In a lot of places (I greped "if +not +\w+:" and found tons of these) the function definition says <variable>=None and then check if the variable is false then creates an empty var. In python empty vars are usually false, so if someones passes an empty var the function will create a new one, both creating more objects than it needs to and making it way harder to test openerp code. Changing it to if <variable> is None is both more semantically correct and will make the problem go away. To manage notifications about this bug go to: https://bugs.launchpad.net/openobject-server/+bug/814620/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~c2c-oerpscenario Post to : [email protected] Unsubscribe : https://launchpad.net/~c2c-oerpscenario More help : https://help.launchpad.net/ListHelp
