> I do not see a good reason of using the valuation_out_account_id instead of > valuation_in_account_id especially as the label "Stock Input Account" > indicates the same purpose for all 3 fields.
Here is the reason: these fields are in fact the exact opposite of the "Stock output account"/"Stock input account" on a product, as Kirti tried to explain. Perhaps they should better be named "Stock Valuation Account (Incoming)" and "Stock Valuation Account (Outgoing)", and have a better tooltip explaining that they represent specific Stock Valuation Accounts to use for *virtual* locations only. This would indeed avoid confusion due to similar labels. More details: The addition of these fields is a modified replacement of the unique "account_id" from v5 which was the equivalent of the new "property_stock_valuation_account_id" that is located on the product category. We had a request to be able to specify a different valuation account for incoming and outgoing moves, typically in order to have separate "Inventory Loss" and "Inventory Recovery" accounts (-> bug 697273) As of 6.0. any move that makes goods enter or exit the company can trigger a valuation move that does the following: - For incoming: debit/increase the valuation account, credit/decrease the counterpart account (Stock Input Account) - For outgoing: credit/decrease the valuation account, debit/increase the counterpart account (Stock Output Account) (For internal moves: no valuation entry) Taking an example of inventory loss event, we expect to see the following valuation moves: 1. Without any counterpart account set on the locations ------------------------------------------------------- STOCK MOVE: Internal Location | Inventory Loss Location -2 PCE | +2 PCE ACCOUNT MOVE: Valuation Acct | Stock Output Acct Credit 2*cost | Debit 2*cost 2. With an "Inventory Loss Acct" set as "valuation_in_account_id" on "Inventory Loss" location ------------------------------------------------------------------------------------------------- STOCK MOVE: Internal Location | Inventory Loss Location -2 PCE | +2 PCE ACCOUNT MOVE: Valuation Acct | Inventory Loss Acct Credit 2*cost | Debit 2*cost As we can see the "valuation_in_account_id" property represents the equivalent of a "Stock Valuation Account" that would hold the value of the "Inventory Loss" location, and would thus increase (be debited) when new goods come INTO the Inventory Loss location. So yes, it will replace the generic "Stock output account", but it derives from a *specific INPUT* rule, rather than a *generic OUTPUT* rule. A "Stock Output Account" is a *generic* counterpart for goods *leaving* the company, while "valuation_in_account_id" is a *specific* valuation account for a given virtual location receiving *incoming* goods. The code logic seem correct to me, and the technical name of the column as well. But we need to find a better label and tooltip to avoid confusion. -- You received this bug notification because you are a member of C2C OERPScenario, which is subscribed to OpenERP Project Group. https://bugs.launchpad.net/bugs/890193 Title: stock wrong help text Status in OpenERP Addons (modules): New Bug description: IMHO the help text is wrong for both accounts in must match in and out must match out stock/stock.py 'valuation_in_account_id': fields.many2one('account.account', 'Stock Input Account',domain = [('type','=','other')], help='This account will be used to value stock moves that have this location as destination, instead of the stock output account from the product.'), 'valuation_out_account_id': fields.many2one('account.account', 'Stock Output Account',domain = [('type','=','other')], help='This account will be used to value stock moves that have this location as source, instead of the stock input account from the product.'), To manage notifications about this bug go to: https://bugs.launchpad.net/openobject-addons/+bug/890193/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~c2c-oerpscenario Post to : [email protected] Unsubscribe : https://launchpad.net/~c2c-oerpscenario More help : https://help.launchpad.net/ListHelp
