> -----Original Message----- > From: Christopher Lenz [mailto:[EMAIL PROTECTED] > Sent: 19 March 2003 13:24 > To: Cactus Developers List > Subject: Re: cvs commit: jakarta- > cactus/integration/ant/src/java/org/apache/cactus/integration/ant > WebXmlMergeTask.java
[snip] > >>In this case, the exception does get thrown. Okay, it's a unckecked > >>exception, but still should be documented IMHO. > > > > Arg! Eclipse was telling it was unused... it was apparently lying to me! > > Should we write instead: > > > > private void checkElement(Element theElement, WebXmlTag > > theExpectedTag) > > throws IllegalArgumentException > > > > ? > > > > That would be to prevent code verification tools to give warnings. > > > > If Checkstyle doesn't complain, that'd be okay with me. It doesn't. BTW, we are already declaring "throws BuildException" in several places in the code (including in Web.xml). Thanks -Vincent > > -chris > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
