Please note that I have also removed the previous nightly build that I had uploaded and replaced it with a new version containing the lastest fix for the problem below.
Volker, could you please try it out? Thanks -Vincent > -----Original Message----- > From: Vincent Massol [mailto:[EMAIL PROTECTED] > Sent: dimanche 27 juin 2004 17:24 > To: 'Cactus Users List' > Subject: RE: ServletTestRunner and multiple Web Applications > > > > > -----Original Message----- > > From: Kazuhito SUGURI [mailto:[EMAIL PROTECTED] > > Sent: dimanche 27 juin 2004 16:46 > > To: [EMAIL PROTECTED] > > Subject: Re: ServletTestRunner and multiple Web Applications > > > > Hi Vincent, > > > > In article <[EMAIL PROTECTED]>, > > Sun, 27 Jun 2004 13:11:15 +0200, > > "Vincent Massol" <[EMAIL PROTECTED]> wrote: > > vmassol> Ok, I've committed the fix for the ServletTestRunner. I haven't > > written any > > vmassol> automated test case for it though... :-( (it's quite hard to > > do...) > > vmassol> > > vmassol> Could you let me know if it works? (I've uploaded a nightly > build > > in > > vmassol> http://cvs.apache.org/builds/jakarta-cactus/nightly/2004-06- > 27/). > > > > The committed change may not work for Volker. > > ConfigurationInitializer#addSystemProperties() will not change > > system property value if the one already exists. > > > > > private static void addSystemProperties(ResourceBundle theBundle) > > > { > > > Enumeration keys = theBundle.getKeys(); > > > > > > while (keys.hasMoreElements()) > > > { > > > String key = (String) keys.nextElement(); > > > // Only set the system property if it does not already > exist. > > > // This allows to have a cactus properties file and > override > > > // some values on the command line. > > > if (System.getProperty(key) == null) > > > { > > > System.setProperty(key, theBundle.getString(key)); > > > } > > > } > > > } > > True... :-) > > > > > Can we change the logic without breaking other use cases? > > I've committed a second attempt... Let me know if you think it cannot > work. I think I have preserved the existing use cases. > > Thanks! > -Vincen > > --- > Outgoing mail is certified Virus Free. > Checked by AVG anti-virus system (http://www.grisoft.com). > Version: 6.0.711 / Virus Database: 467 - Release Date: 25/06/2004 > --- Outgoing mail is certified Virus Free. Checked by AVG anti-virus system (http://www.grisoft.com). Version: 6.0.711 / Virus Database: 467 - Release Date: 25/06/2004 --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
