William, Looks good.
John William Schumann wrote: > John, > Please take one more look at the updated webrev to check my language in > auto_install.c. > http://cr.opensolaris.org/~wmsch/bug-12459/ > Thank you, > William > > John Fischer wrote: >> William, >> >> Actually, simply adding an 'or' to the 'create a Solaris partition use >> the manifest' would probably do it. >> >> Or your other method would work as well. >> >> Thanks, >> >> John >> >> >> William Schumann wrote: >>> John, >>> John Fischer wrote: >>>> The help message seems a little confusing to me. It reads: >>>> >>>> To fix the problem, the user can do the following: >>>> - delete unused partitions using the manifest, >>>> - create a Solaris partition using the manifest, >>>> - or create a Solaris partition before running the installer. >>>> >>>> Does this mean that: >>>> >>>> 1) the user can delete the unused partitions and create >>>> a Solaris partition via the manifest Or the user can create >>>> a Solaris partition before running the installer? >>> If the user deletes all unused partitions, then the default behavior >>> is to create a Solaris partition using the entire disk, and it is not >>> necessary to do an explicit create in the manifest. >>>> >>>> Or 2) the user can do any one of the 3 options? >>> To put it another way, >>> - the user must explicitly create a Solaris partition using the >>> manifest if partitions of other IDs exist >>> - if the disk has no partitions, or if the user has specified the >>> deletion of any existing partitions in the manifest, the default >>> action is to create a Solaris partition on the entire disk >>> >>> To change it so that you have 3 mutually exclusive options: >>> I) create a Solaris partition using the manifest >>> II) or create a Solaris partition manually >>> III) or delete all non-Solaris partitions, either through the >>> manifest or manually, and a Solaris partition will be created using >>> the entire disk >>> >>> Does this seem more useful? >>> >>> William >>> >>> But when you put it this way, I) is >>>> >>>> If it means the later then perhaps the first line should read: >>>> >>>> To fix the problem, the user can do one of the following: >>>> >>>> Or is it one of those options where the user can do multiple >>>> responses separately or in combination. >>>> >>>> Thanks, >>>> >>>> John >>>> >>>> >>>> William Schumann wrote: >>>>> webrev: http://cr.opensolaris.org/~wmsch/bug-12459/ >>>>> >>>>> If no Solaris partition was either pre-existing, specified in AI >>>>> manifest, or specified from AI default action on selected disk, >>>>> om_perform_slim_install was not returning OM_FAILURE, leading AI to >>>>> misread the returned status and continue waiting. Fixed return >>>>> code and >>>>> improved user instructions and log messages. >>>>> >>>>> Tested AI: >>>>> - creating missing Solaris scenario >>>>> - providing Solaris partition >>>>> Tested GUI: >>>>> - GUI does not reach this code, since the GUI requires a Solaris >>>>> partition to exist or to be requested before the user can proceed with >>>>> the installation. >>>>> >>>>> _______________________________________________ >>>>> caiman-discuss mailing list >>>>> caiman-discuss at opensolaris.org >>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
