Hi Keith, thank you for your comments - I have accepted almost all of them - please see below.
I have updated webrev accordingly - it now contains only changes related to your comments: http://cr.opensolaris.org/~dambi/python-24-26/ Thank you, Jan Keith Mitchell wrote: > ai_get_manifest [...] > 629-631: This no longer will "return None, -1" - is this intended? Nope. Thank you for catching this - I have changed it. > > 787: If this needs to be done, is there a bug on it? If so, just > remove the line entirely (or reference the bug). If not, can you file > a bug on this? I filed bug 12494 made reference to it in the comment. > > ai_sd.py: [...] > > > 401-402: This line would be more readable if split up. I am not sure how you would like to have it split up. Could you please elaborate more on this ? [...] > > > > > ai_get_manifest: [...] > 216-224: The 'platform' python module provides this functionality > internally. Alternatively, os.uname() also exposes this data. > Same comments for code in AICriteriaPlatform and AICriteriaCPU Well, I would prefer not to change this part at this point - also I haven't found equivalent for 'uname -i' - do you happen to know if there is one in 'platform' or 'os' module ?
