Hi Keith,
On Wed, 4 Nov 2009, Keith Mitchell wrote:
> Hi Alok,
>
> Just a few questions on the updated webrev, in transfer_mod.py:
>
> 144: Why did you change from using "super()"? I'm just curious, as from what
> I've seen, both syntaxes are equally "correct" when considering single
> inheritance.
I was seeing weird problems at runtime with super(). After
spending an inordinate amount of time with Dave Marker trying
to figure out why that error was there, we decided to not waste
any more time.
> 472: The first part of this 'if' statement should stay as it was
> ('old_cprefix != cp.chdir_prefix').
>
> 560, 562: Use "negate" and "not negate" here instead of "negate == True" /
> "negate == False"
> 590: If this fits on the previous line, it would be better off there.
Changed.
> Everything else looks good. Also, your assessment of which comments to
> defer/skip works for me.
Thanks for taking a second look.
Alok
