Alok Aggarwal wrote: > > On Thu, 5 Nov 2009, jeanm wrote: > >> I'd like Jan and Alok to please review the following: >> >> http://cr.opensolaris.org/~jeanm/slim_8347_6092/ >> >> The bugs addressed are the following: >> >> 6092 <http://defect.opensolaris.org/bz/show_bug.cgi?id=6092> Rename >> bootroot to boot_archive in DC >> 8347 <http://defect.opensolaris.org/bz/show_bug.cgi?id=8347> Move >> boot archive from /boot/x86 >> <http://defect.opensolaris.org/bz/show_bug.cgi?id=86>.microroot to >> /platform/i86 >> <http://defect.opensolaris.org/bz/show_bug.cgi?id=86>pc/boot_archive > > DC-manifest.rng: line 468, 488: s/Tweeks/Tweaks done. > > ai_plat_setup.py: Thanks for picking this file up for me, > will make the merge easier for me :) The #! python line > will need to be changed when you push to the python2.6 > gate. Yes. All files I have that have the #!/usr/bin/python2.4 at the top will change to 2.6 when I push to the python2.6 gate.
> > ai_plat_setup.py: line 79: I think a comment should be added > here that the sun4u/boot_archive is the real boot_archive and > it is the same for both sun4u/sun4v? done. > > dc_ti.py: line 1: Why is this needed? It shouldn't be. Removed. > > dc_ti.py: line 376: Do we really want to except on Exception > here? > No. That is fixed in the pylint changes. I didn't want to put very many pylint changes into this webrev because I was afraid it would mask the real changes. The python2.6 gate has this change and when I merge it will show up. > distro_const.py: line 275: This can be changed to: > if do_list and (pause or resume): See above comment. > > distro_const.py: line 283: do_list is a boolean so the > statement can just be 'if do_list:' See above. > > boot_archive_archive.py: line 288: if BA_COMPR_LEVEL is None See above. > > boot_archive_archive.py: line 294, 301: Same as above And the same answer. I will double check these when I do the python2.6 merge. Jean > > Alok
