Jan, I have done as you suggested and removed the pylint disable_msg tags.
The updated webrev is at: http://cr.opensolaris.org/~joev/PY26/ Thanks! Joe Joseph J. VLcek wrote: > Jan Damborsky wrote: >> Hi Joe, >> >> I have reviewed 2.4->2.6 changes and they look good to me. >> As far as PEP8 stuff is concerned, the SNR ratio is so low that >> I will let pylint and test cycle (which is going to be extensive >> and detailed anyway) reveal any potential regressions. >> >> I have only one generic comment with respect to making >> code pylint clean. Looking at ict.py file, there are couple places >> where pylint complaints are suppressed by means of >> '# pylint: disable-msg...' >> To be honest, I am not quite convinced that they should be part >> of code and I might recommend to remove them. >> I think it is fine if we don't address those issues now, but we >> shouldn't suppress them, since my understanding is that whoever >> is going to address them later will need to remove all that stuff >> anyway. >> >> Thank you, >> Jan > > Thank you Jan! > > I agree removing the "#pyling: disable-msg..." lines is the correct > thing to do. > > Joe > > > >> >> >> Joseph J. VLcek wrote: >>> Please review the ICT code changes for the Python2.6 conversion, >>> which includes PEP8 compliance. >>> >>> Note: install-finish pylint results: rated at 9.94/10 This is because >>> of one error due to the file name not conforming to PEP8. I do not >>> want to change this at this time. ict.py pylint results are a 10/10. >>> >>> The webrev is here: http://cr.opensolaris.org/~joev/PY26/ >>> >>> Bug 6256 has been filed against the ICT code and will include work to >>> "Python-ize" it. Attempting to prevent the introduction of bugs, I >>> altered the code as little as possible. Any "Python-izing" feedback >>> may be incorporated when addressing Bug 6256. >>> >>> I was able to test far more extensively then I had reported in our >>> meeting on Friday. With help from Jean and Keith I was able to >>> exercise the pkg Python2.4 code from the updated ICT Python 2.6 code. >>> Thanks Jean and Keith! >>> >>> Testing: >>> ------------ >>> >>> An alternate root was populated in an extra disk on an x86 test system. >>> >>> I then exercised individual ICT's from the command line. >>> >>> I then installed SUNWinstall from my Python2.6 work gate and ran the >>> updated install-finish script. >>> >>> All tests passed. See below for a details. >>> >>> Thank you! Joe >>> >>> --- >>> Set Up for an alternate root on keelhaul.east >>> --------------------------------------------- >>> >>> >>> pfexec su >>> zpool create -f rpool_ICT c1t1d0 >>> zfs create rpool_ICT/ROOT >>> zfs set mountpoint=legacy rpool_ICT/ROOT >>> zfs create rpool_ICT/ROOT/opensolaris >>> mkdir /a >>> mount -F zfs rpool_ICT/ROOT/opensolaris /a >>> >>> Populate the alternate root >>> --------------------------- >>> >>> ROOT=/a >>> pkg image-create --full -a opensolaris=http://ipkg.sfbay/dev/ >>> ${ROOT} >>> pkg -R ${ROOT} install SUNWcsd >>> pkg -R ${ROOT} install SUNWcs >>> pkg -R ${ROOT} install slim_install >>> >>> TESTING ict.py >>> -------------------------------------------------------- >>> >>> cd /usr/lib/python2.6/vendor-packages >>> ln -s /usr/lib/python2.4/vendor-packages/osol_install . >>> ln -s /usr/lib/python2.4/vendor-packages/pkg . >>> export LS_DBG_LVL=4 >>> python2.6 ./ict.py ict_test /a >>> python2.6 ./ict.py create_smf_repository /a >>> python2.6 ./ict.py create_mnttab /a >>> python2.6 ./ict.py cleanup_unneeded_files_and_dirs /a >>> python2.6 ./ict.py keyboard_layout /a >>> python2.6 ./ict.py delete_misc_trees /a >>> python2.6 ./ict.py set_prop_from_eeprom /a 3 keyboard-layout >>> >>> ... >>> >>> >>> TESTING install-finish >>> ---------------------- >>> >>> cd <my work gate>/PY26/usr/src/ >>> time ./nightly -n developer.sh; echo "nightly status --->$?<---" >>> >>> >>> Then on my test system, keelhaul, do: >>> >>> cd <my work gate>/PY26/packages/i386/nightly-nd >>> pkgadd -d . SUNWinstall >>> >>> >>> >>> /sbin/install-finish -B '/a' -R >>> '$5$Qab1tmRb$r359i65Bj0tRvBeudY6VjwrDpXRGoTm.4v0Ir6cdht7' -n 'Joe >>> VLcek' -l 'guest' -p >>> '$5$0H2JAt1i$G4BeRrCwIWzrPMBfcsNj4MKEtGp2fk4/Mk/W9jI4lR8' -G '10' -U >>> '101' >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> > >
