Hi Jack, Everything looks good now! I'm glad that this review has been helpful.
- Keith Jack Schwartz wrote: > HI Keith. > > Thanks for your second reply. > > Keith Mitchell wrote: >> Hi Jack, >> >> Everything looks good. I have a few followup comments, below, but >> they're mostly nits and explanations of my thought processes. > Phew! (Just kidding...) >> >> I know I've been rather nitpicky with this and other Python CRs. I >> can't seem to help myself... small, gritty details for some reason >> catch my eye. > It's taken some time, but I've also learned a lot along the way, so > it's been useful. > > More comments below. I've "snipped out" the stuff I have no comment on. >> >> Thanks for your patience! >> - Keith >>>> >>>> install_utils.py: >>>> 255-265: Could be simplified to: >>>> try: >>>> int(arg, 0) >>>> float(arg) >>>> return True >>>> except ValueError: >>>> return False >>> Nope. "0x123" will get caught on the float and return false. >> >> You're correct on that count, 2 separate try/except blocks are >> needed. However, the "dummy =" portion can be removed. > Leaving the "dummy =" in makes the code clearer IMO. While I don't agree 100%, it's just a personal style thing, so it's ok to leave it in.
