Evan Layton wrote: > Evan Layton wrote: >> Keith Mitchell wrote: >>> Hi Luis, >>>> >>>>> other changes from 'not <y>.has_key(<x>)' >>>>> 180: isinstance (I must've missed this first go around, sorry!) >>>> isinstance needs the 2 argument to be a class or an object. python >>>> raises an error if it is a string, which is what happens in this case. >>> >>> Apologies, I should have been more explicit. As we discussed, the >>> correct syntax is: >>> isinstance(self, BEList): >>> >>> Note that I'm passing in BEList (the class) not "BEList" (the string) >>> >> >> Since the use of this has completely broken beadm I would prefer if >> we could put this off until a later date. We would like to get the 2.6 >> changes pushed without further delays and this change in particular is >> causing testing and debug issues. If this is OK I'll revert this change >> and send out an updated webrev. >> >> Thanks! >> -evan > > The new incremental webrev is available at: > http://cr.opensolaris.org/~evanl/11679v3 > > These changes have been tested and work correctly... > > -evan > Awesome! I was getting worried about this :)
Luis >> >>>> >>>> Thank you for the great review! See you next week :) >>> >>> I look forward to meeting you! >>> >>> - Keith >>> >>>> >>>> Luis >>>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
