John Fischer wrote:
> All,
>
> Fairly straight forward fix to a PATH issue. Low hanging fruit for the
> new guy. More exciting things to come next week. ;-)
>
> webrev:
>
> http://cr.opensolaris.org/~johnfisc/path-7325/
>
> Open Solaris defect:
>
> 7325 - installadm script should set PATH
>
> The fix is to use putenv() of a sensible path which is /usr/bin,
> /usr/sbin and /usr/lib/installadm. Only set once for the process
> via an initialize variable.
>
> When someone has a chance I would appreciate a review.
>
> Thanks,
>
> John
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
John,

I think having the installadm_system() function in 
usr/src/cmd/installadm/installadm_util.c export a PATH is an simple and 
elegant solution. However I think it might be safer in the long run to 
have each script define PATH.

This would make each script more robust and able to stand on it's own 
without the requirement it be invoked by installadm_system().

My concern is what happens if in the future a code change is made to 
have the scripts no longer invoked by installadm_system().

What do you think?

Joe


installadm_system


Reply via email to