Hi Jack, DefaultsModule.py 61: I think you need to re-enable the pylint message afterwards, or it will be quieted for the remainder of the module (and any other modules that happen to get checked). Alternatively, I believe we have it set so if you use the name "dummy" as the parameter, pylint ignores the unused parameter
DefValProc.py: 826: Slight alignment issue (should be aligned with the parentheses) Everything else looks good. - Keith Jack Schwartz wrote: > Hi everyone. > > Please review changes for the following: > 12662 <http://defect.opensolaris.org/bz/show_bug.cgi?id=12662> DC error: > get_value_from_helper: Helper method deflt_distro_name raised an exception > 12670 <http://defect.opensolaris.org/bz/show_bug.cgi?id=12670> Change nested > try/except in distro_const.py missed during 2 > <http://defect.opensolaris.org/bz/show_bug.cgi?id=2>.6 > <http://defect.opensolaris.org/bz/show_bug.cgi?id=6> python porting > > http://cr.opensolaris.org/~schwartz/091113.1/webrev/ > > These things relate to issues found during python 2.6 porting testing. > > Thanks, > Jack > > ------------------------------------------------------------------------ > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
