Looks good to me. One nit, you should run cstyle -pP on it. I think line 592 has an issue.
Jean Moriah Waterland wrote: > I'd appreciate a code review for the following installadm fixes: > > 4521 create-service: not getting error message when only passing "-c" > option. > http://defect.opensolaris.org/bz/show_bug.cgi?id=4521 > > 4523 create-service: not getting error message when only passing "-i" > option. > http://defect.opensolaris.org/bz/show_bug.cgi?id=4523 > > > 4531 create-service: successful when -c option is passed a negative > number. > http://defect.opensolaris.org/bz/show_bug.cgi?id=4531 > > > My webrev is at: > http://cr.opensolaris.org/~mwaterl/f4521 > > > These fixes clean up the error handling with the "-c"and "-i" options > for installadm create-service. I also filed this RFE: > Bug 12779 create-service should assume at least one valid dhcp addr > when "-i "argument is supplied > > I completed unit testing and verified that installadm correctly errors > out when the "-c" and "-i" options are incorrectly specified. > > > thanks, > > ---- > Moriah Waterland > Software Engineer > Solaris Core OS > Sun Microsystems > 303-272-7448 > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
